Support async logic into rules set

microlinkhq · Feb 13, 2018 · 06fa950 · 06fa950
1 parent a4c6c54
commit 06fa950
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/metascraper/package.json b/packages/metascraper/package.json
@@ -69,6 +69,7 @@
     "metascraper-title": "^3.8.0",
     "metascraper-url": "^3.8.0",
     "metascraper-video": "^3.8.0",
+    "p-reduce": "~1.0.0",
     "resolve-from": "~4.0.0",
     "sanitize-html": "~1.17.0"
   },

diff --git a/packages/metascraper/src/get-data.js b/packages/metascraper/src/get-data.js
@@ -1,24 +1,25 @@
 'use strict'
 
-const { reduce, isEmpty } = require('lodash')
+const { isEmpty } = require('lodash')
+const pReduce = require('p-reduce')
 
-const getValue = ({ htmlDom, url, conditions, meta }) => {
+const getValue = async ({ htmlDom, url, conditions, meta }) => {
   const size = conditions.length
   let index = -1
   let value
 
   while (isEmpty(value) && index++ < size - 1) {
-    value = conditions[index]({ htmlDom, url, meta })
+    value = await conditions[index]({ htmlDom, url, meta })
   }
 
   return value
 }
 
 const getData = ({ rules, htmlDom, url }) =>
-  reduce(
+  pReduce(
     rules,
-    (acc, [propName, conditions]) => {
-      const value = getValue({ htmlDom, url, conditions, meta: acc })
+    async (acc, [propName, conditions]) => {
+      const value = await getValue({ htmlDom, url, conditions, meta: acc })
       acc[propName] = !isEmpty(value) ? value : null
       return acc
     },