From 0e1b97a144237d293b2bfa6a3667883b729b3008 Mon Sep 17 00:00:00 2001 From: Tobias Lidskog Date: Mon, 23 Jan 2017 19:22:35 +0100 Subject: [PATCH] Fix incorrect time formatting for first request. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use new millisecond formatter to avoid ”(undefined after page request started)” in the ”Started” section of the detail overlay for the first request (which is often 0 milliseconds after start). Now writes ”(0 ms after page request started)” as expected. --- src/ts/waterfall/details-overlay/extract-details-keys.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/ts/waterfall/details-overlay/extract-details-keys.ts b/src/ts/waterfall/details-overlay/extract-details-keys.ts index 40d59b42..c3ce5717 100644 --- a/src/ts/waterfall/details-overlay/extract-details-keys.ts +++ b/src/ts/waterfall/details-overlay/extract-details-keys.ts @@ -33,8 +33,6 @@ let ifValueDefined = (value: number, fn: (_: number) => any) => { let formatBytes = (size?: number) => ifValueDefined(size, (s) => `${s} byte (~${Math.round(s / 1024 * 10) / 10}kb)`); -let formatTime = (size?: number) => ifValueDefined(size, (s) => `${s} ms`); - const formatDate = (date?: string) => { if (!date) { return undefined; @@ -70,8 +68,8 @@ function parseGeneralDetails(entry: WaterfallEntry, requestID: number): KvTuple[ return [ ["Request Number", `#${requestID}`], ["Started", new Date(harEntry.startedDateTime).toLocaleString() + ((entry.start > 0) ? - " (" + formatTime(entry.start) + " after page request started)" : "")], - ["Duration", formatTime(harEntry.time)], + " (" + formatMilliseconds(entry.start) + " after page request started)" : "")], + ["Duration", formatMilliseconds(harEntry.time)], ["Error/Status Code", harEntry.response.status + " " + harEntry.response.statusText], ["Server IPAddress", harEntry.serverIPAddress], ["Connection", harEntry.connection],