Skip to content

Commit

Permalink
Fix incorrect time formatting for first request.
Browse files Browse the repository at this point in the history
Use new millisecond formatter to avoid ”(undefined after page request started)” in the ”Started” section of the detail overlay for the first request (which is often 0 milliseconds after start). Now writes ”(0 ms after page request started)” as expected.
  • Loading branch information
tobli committed Feb 6, 2017
1 parent b37735a commit 0e1b97a
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/ts/waterfall/details-overlay/extract-details-keys.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ let ifValueDefined = (value: number, fn: (_: number) => any) => {

let formatBytes = (size?: number) => ifValueDefined(size, (s) => `${s} byte (~${Math.round(s / 1024 * 10) / 10}kb)`);

let formatTime = (size?: number) => ifValueDefined(size, (s) => `${s} ms`);

const formatDate = (date?: string) => {
if (!date) {
return undefined;
Expand Down Expand Up @@ -70,8 +68,8 @@ function parseGeneralDetails(entry: WaterfallEntry, requestID: number): KvTuple[
return [
["Request Number", `#${requestID}`],
["Started", new Date(harEntry.startedDateTime).toLocaleString() + ((entry.start > 0) ?
" (" + formatTime(entry.start) + " after page request started)" : "")],
["Duration", formatTime(harEntry.time)],
" (" + formatMilliseconds(entry.start) + " after page request started)" : "")],
["Duration", formatMilliseconds(harEntry.time)],
["Error/Status Code", harEntry.response.status + " " + harEntry.response.statusText],
["Server IPAddress", harEntry.serverIPAddress],
["Connection", harEntry.connection],
Expand Down

0 comments on commit 0e1b97a

Please sign in to comment.