Skip to content

Commit

Permalink
Don’t warn about missing MIME for 204 responses.
Browse files Browse the repository at this point in the history
It’s expected for 204 No Content responses to lack MIME type, since it’s not applicable.
  • Loading branch information
tobli committed Feb 11, 2017
1 parent 606eb0e commit 0a5eb99
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/ts/waterfall/row/svg-indicators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ export function getMimeTypeIcon(entry: WaterfallEntry): Icon {
output.push(makeIcon("noGzip", "no gzip"));
}

if (!harEntry.response.content.mimeType && heuristics.isInStatusCodeRange(harEntry, 200, 299)) {
if (!harEntry.response.content.mimeType &&
heuristics.isInStatusCodeRange(harEntry, 200, 299) &&
harEntry.response.status !== 204) {
output.push(makeIcon("warning", "No MIME Type defined"));
}

Expand Down

0 comments on commit 0a5eb99

Please sign in to comment.