-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lsp): add 'zk.link' LSP command #284
Conversation
Allows users to take advantage of the linking mechanism in their editing tools outside of the 'zk.new' context. For example, I made a "ZkInsertLink" command that inserts a link at the current cursor location after searching for the desired note. This improves on the current behavior which only autocompletes based on note name, which users may or may not remember.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, this will be very useful!
Would you mind updating the documentation to add the new zk.link
command?
Could you also |
Some extra bool values were previously returned in linkNote and the zk.link LSP command. These values were vestigial placeholders from the initial refactor, in case extra information was useful. It turns out this was not the case.
Also updates CHANGELOG to reflect the zk.link contribution
Done! Added your suggestions and the changelog patch. As I note in the commits, the I also have this LSP command used in my patch to And I have some example commands in my dotfiles that use Would you be interested in a PR for these on |
Looks like the build fails with the recent changes.
Sure! That would be useful. Thanks again. |
Whoops! Thought I caught all of those refactors. |
Allows users to take advantage of the linking mechanism in their editing tools outside of the 'zk.new' context. For example, I made a "ZkInsertLink" command with Neovim that inserts a link at the current cursor location after searching for the desired note. This improves on the current behavior which only autocompletes based on note name, which users may or may not remember.
I looked for a
CONTRIBUTING.md
but couldn't find. I hope you find this PR useful!Changes
executeCommandNew
into utility function to be used by bothexecuteCommandNew
andexecuteCommandLink