-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow different options for FzF in interactive filtering #137
Comments
Thank you for the kind words!
That sounds like a good strategy. The user options could be specified in the configuration file: [tool]
fzf-options = "--height 40%" Would you be interested in contributing a PR for this? |
I will try to see in the next few days if I can come up with something, though I have never really written a single line of Go before. The issue doesn't seem too complicated though, so maybe I'll be able to get something working and this would be a good introduction to the language. I'll let you know how this goes! |
Thanks, you can create a draft PR and if you check the "Allow edit from maintainers" checkbox while creating the PR I can finish it for you if needed. |
|
Thank you for the tool, it is a brilliant piece of software which I'm enjoying very much!
One of thing I wish would be possible is adjusting the FZF parameters. The one I'm thinking most is
--height 40%
(instead of 100% inzk edit -i
). I've looked a bit at the code and it seems to be set ininternal/adapter/fzf/fzf.go:75
.One solution would be to prepend that list of arguments with the env variable
$FZF_DEFAULT_OPTS
if it exists, and append to the list custom options that could be defined in the.zk/config.toml
. This would make the default config for fzf in zk override the defaultfzf
config (makes sense to me) but would still allow users to override thezk
default config (fzf --height 100% --height 40%
results in height at 40%).Do you think this would be possible?
The text was updated successfully, but these errors were encountered: