Revert "src: fix delete operator on vm context"

This reverts commit 587857e. It was found to have subtle behavior changes in deleting objects. PR-URL: nodejs/node#12721 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
michielbaird · Jul 19, 2017 · a8107a3 · a8107a3
1 parent 1078086
commit a8107a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -441,12 +441,8 @@ class ContextifyContext {
 
     Maybe<bool> success = ctx->sandbox()->Delete(ctx->context(), property);
 
-    if (success.FromMaybe(false))
-      return;
-
-    // Delete failed on the sandbox, intercept and do not delete on
-    // the global object.
-    args.GetReturnValue().Set(false);
+    if (success.IsJust())
+      args.GetReturnValue().Set(success.FromJust());
   }
 
 

diff --git a/test/parallel/test-vm-deleting-property.js → ...known_issues/test-vm-deleting-property.js b/test/parallel/test-vm-deleting-property.js → ...known_issues/test-vm-deleting-property.js
@@ -12,4 +12,4 @@ const res = vm.runInContext(`
   Object.getOwnPropertyDescriptor(this, 'x');
 `, context);
 
-assert.strictEqual(res, undefined);
+assert.strictEqual(res.value, undefined);