Update PHPStan config and baseline

jolelievre · jolelievre · commit 88016e8a11f3 · 2024-11-29T20:03:28.000+01:00
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -12,7 +12,7 @@ parameters:
 
 		-
 			message: "#^Class AbstractAssetManager is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 4
+			count: 8
 			path: src/Core/Addon/Theme/Theme.php
 
 		-
@@ -307,7 +307,7 @@ parameters:
 
 		-
 			message: "#^Class Mail is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/Core/Domain/CustomerService/CommandHandler/AddOrderCustomerMessageHandler.php
 
 		-
@@ -597,7 +597,7 @@ parameters:
 
 		-
 			message: "#^Class CustomerThread is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 2
+			count: 3
 			path: src/Core/Domain/CustomerService/Repository/CustomerThreadRepository.php
 
 		-
@@ -612,7 +612,7 @@ parameters:
 
 		-
 			message: "#^Class Store is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 3
+			count: 4
 			path: src/Core/Domain/Store/Repository/StoreRepository.php
 
 		-
@@ -637,7 +637,7 @@ parameters:
 
 		-
 			message: "#^Class OrderReturn is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/Core/Form/IdentifiableObject/DataHandler/OrderReturnFormDataHandler.php
 
 		-
@@ -722,7 +722,7 @@ parameters:
 
 		-
 			message: "#^Class Db is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 2
+			count: 3
 			path: src/Core/Module/HookRepository.php
 
 		-
@@ -792,7 +792,7 @@ parameters:
 
 		-
 			message: "#^Class Db is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/Core/Repository/AbstractMultiShopObjectModelRepository.php
 
 		-
@@ -862,7 +862,7 @@ parameters:
 
 		-
 			message: "#^Class Shop is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 9
+			count: 17
 			path: src/Core/Shop/LogoUploader.php
 
 		-
@@ -907,7 +907,7 @@ parameters:
 
 		-
 			message: "#^Class Pack is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 11
+			count: 22
 			path: src/Core/Stock/StockManager.php
 
 		-
@@ -1017,7 +1017,7 @@ parameters:
 
 		-
 			message: "#^Class ImageManager is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/EmployeeController.php
 
 		-
@@ -1027,7 +1027,7 @@ parameters:
 
 		-
 			message: "#^Class ImageManager is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/ProfileController.php
 
 		-
@@ -1067,7 +1067,7 @@ parameters:
 
 		-
 			message: "#^Class Dispatcher is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/PrestaShopBundle/Controller/Admin/LegacyController.php
 
 		-
@@ -1117,7 +1117,7 @@ parameters:
 
 		-
 			message: "#^Class ImageManager is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/PrestaShopBundle/Controller/Admin/Sell/Catalog/CategoryController.php
 
 		-
@@ -1152,7 +1152,7 @@ parameters:
 
 		-
 			message: "#^Class CartRule is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/PrestaShopBundle/Controller/Admin/Sell/Order/CartController.php
 
 		-
@@ -1237,12 +1237,12 @@ parameters:
 
 		-
 			message: "#^Class Product is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/PrestaShopBundle/Entity/Repository/StockManagementRepository.php
 
 		-
 			message: "#^Class Shop is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 2
+			count: 3
 			path: src/PrestaShopBundle/Entity/Repository/StockManagementRepository.php
 
 		-
@@ -1317,7 +1317,7 @@ parameters:
 
 		-
 			message: "#^Class Validate is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/PrestaShopBundle/Form/Admin/Sell/Customer/CustomerType.php
 
 		-
@@ -1372,7 +1372,7 @@ parameters:
 
 		-
 			message: "#^Class PrestaShopLogger is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 4
+			count: 8
 			path: src/PrestaShopBundle/Form/Admin/Type/LogSeverityChoiceType.php
 
 		-
@@ -1382,7 +1382,7 @@ parameters:
 
 		-
 			message: "#^Class Dispatcher is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
-			count: 1
+			count: 2
 			path: src/PrestaShopBundle/Routing/LegacyRouterChecker.php
 
 		-
@@ -1420,6 +1420,11 @@ parameters:
 			count: 1
 			path: src/PrestaShopBundle/Twig/Component/AbstractMultistoreHeader.php
 
+		-
+			message: "#^Class Shop is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
+			count: 2
+			path: src/PrestaShopBundle/Twig/Component/HeadTag.php
+
 		-
 			message: "#^Namespace AdminController is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"
 			count: 1
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -83,3 +83,4 @@ parameters:
     - _PS_API_IN_USE_
     - _PS_ALLOW_MULTI_STATEMENTS_QUERIES_
     - _PS_DISPLAY_ONLY_ERRORS_
+  treatPhpDocTypesAsCertain: false

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ parameters:`
`12`	`12`
`13`	`13`	`-`
`14`	`14`	`message: "#^Class AbstractAssetManager is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`15`		`- count: 4`
	`15`	`+ count: 8`
`16`	`16`	`path: src/Core/Addon/Theme/Theme.php`
`17`	`17`
`18`	`18`	`-`
`@@ -307,7 +307,7 @@ parameters:`
`307`	`307`
`308`	`308`	`-`
`309`	`309`	`message: "#^Class Mail is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`310`		`- count: 1`
	`310`	`+ count: 2`
`311`	`311`	`path: src/Core/Domain/CustomerService/CommandHandler/AddOrderCustomerMessageHandler.php`
`312`	`312`
`313`	`313`	`-`
`@@ -597,7 +597,7 @@ parameters:`
`597`	`597`
`598`	`598`	`-`
`599`	`599`	`message: "#^Class CustomerThread is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`600`		`- count: 2`
	`600`	`+ count: 3`
`601`	`601`	`path: src/Core/Domain/CustomerService/Repository/CustomerThreadRepository.php`
`602`	`602`
`603`	`603`	`-`
`@@ -612,7 +612,7 @@ parameters:`
`612`	`612`
`613`	`613`	`-`
`614`	`614`	`message: "#^Class Store is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`615`		`- count: 3`
	`615`	`+ count: 4`
`616`	`616`	`path: src/Core/Domain/Store/Repository/StoreRepository.php`
`617`	`617`
`618`	`618`	`-`
`@@ -637,7 +637,7 @@ parameters:`
`637`	`637`
`638`	`638`	`-`
`639`	`639`	`message: "#^Class OrderReturn is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`640`		`- count: 1`
	`640`	`+ count: 2`
`641`	`641`	`path: src/Core/Form/IdentifiableObject/DataHandler/OrderReturnFormDataHandler.php`
`642`	`642`
`643`	`643`	`-`
`@@ -722,7 +722,7 @@ parameters:`
`722`	`722`
`723`	`723`	`-`
`724`	`724`	`message: "#^Class Db is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`725`		`- count: 2`
	`725`	`+ count: 3`
`726`	`726`	`path: src/Core/Module/HookRepository.php`
`727`	`727`
`728`	`728`	`-`
`@@ -792,7 +792,7 @@ parameters:`
`792`	`792`
`793`	`793`	`-`
`794`	`794`	`message: "#^Class Db is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`795`		`- count: 1`
	`795`	`+ count: 2`
`796`	`796`	`path: src/Core/Repository/AbstractMultiShopObjectModelRepository.php`
`797`	`797`
`798`	`798`	`-`
`@@ -862,7 +862,7 @@ parameters:`
`862`	`862`
`863`	`863`	`-`
`864`	`864`	`message: "#^Class Shop is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`865`		`- count: 9`
	`865`	`+ count: 17`
`866`	`866`	`path: src/Core/Shop/LogoUploader.php`
`867`	`867`
`868`	`868`	`-`
`@@ -907,7 +907,7 @@ parameters:`
`907`	`907`
`908`	`908`	`-`
`909`	`909`	`message: "#^Class Pack is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`910`		`- count: 11`
	`910`	`+ count: 22`
`911`	`911`	`path: src/Core/Stock/StockManager.php`
`912`	`912`
`913`	`913`	`-`
`@@ -1017,7 +1017,7 @@ parameters:`
`1017`	`1017`
`1018`	`1018`	`-`
`1019`	`1019`	`message: "#^Class ImageManager is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1020`		`- count: 1`
	`1020`	`+ count: 2`
`1021`	`1021`	`path: src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/EmployeeController.php`
`1022`	`1022`
`1023`	`1023`	`-`
`@@ -1027,7 +1027,7 @@ parameters:`
`1027`	`1027`
`1028`	`1028`	`-`
`1029`	`1029`	`message: "#^Class ImageManager is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1030`		`- count: 1`
	`1030`	`+ count: 2`
`1031`	`1031`	`path: src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/ProfileController.php`
`1032`	`1032`
`1033`	`1033`	`-`
`@@ -1067,7 +1067,7 @@ parameters:`
`1067`	`1067`
`1068`	`1068`	`-`
`1069`	`1069`	`message: "#^Class Dispatcher is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1070`		`- count: 1`
	`1070`	`+ count: 2`
`1071`	`1071`	`path: src/PrestaShopBundle/Controller/Admin/LegacyController.php`
`1072`	`1072`
`1073`	`1073`	`-`
`@@ -1117,7 +1117,7 @@ parameters:`
`1117`	`1117`
`1118`	`1118`	`-`
`1119`	`1119`	`message: "#^Class ImageManager is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1120`		`- count: 1`
	`1120`	`+ count: 2`
`1121`	`1121`	`path: src/PrestaShopBundle/Controller/Admin/Sell/Catalog/CategoryController.php`
`1122`	`1122`
`1123`	`1123`	`-`
`@@ -1152,7 +1152,7 @@ parameters:`
`1152`	`1152`
`1153`	`1153`	`-`
`1154`	`1154`	`message: "#^Class CartRule is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1155`		`- count: 1`
	`1155`	`+ count: 2`
`1156`	`1156`	`path: src/PrestaShopBundle/Controller/Admin/Sell/Order/CartController.php`
`1157`	`1157`
`1158`	`1158`	`-`
`@@ -1237,12 +1237,12 @@ parameters:`
`1237`	`1237`
`1238`	`1238`	`-`
`1239`	`1239`	`message: "#^Class Product is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1240`		`- count: 1`
	`1240`	`+ count: 2`
`1241`	`1241`	`path: src/PrestaShopBundle/Entity/Repository/StockManagementRepository.php`
`1242`	`1242`
`1243`	`1243`	`-`
`1244`	`1244`	`message: "#^Class Shop is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1245`		`- count: 2`
	`1245`	`+ count: 3`
`1246`	`1246`	`path: src/PrestaShopBundle/Entity/Repository/StockManagementRepository.php`
`1247`	`1247`
`1248`	`1248`	`-`
`@@ -1317,7 +1317,7 @@ parameters:`
`1317`	`1317`
`1318`	`1318`	`-`
`1319`	`1319`	`message: "#^Class Validate is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1320`		`- count: 1`
	`1320`	`+ count: 2`
`1321`	`1321`	`path: src/PrestaShopBundle/Form/Admin/Sell/Customer/CustomerType.php`
`1322`	`1322`
`1323`	`1323`	`-`
`@@ -1372,7 +1372,7 @@ parameters:`
`1372`	`1372`
`1373`	`1373`	`-`
`1374`	`1374`	`message: "#^Class PrestaShopLogger is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1375`		`- count: 4`
	`1375`	`+ count: 8`
`1376`	`1376`	`path: src/PrestaShopBundle/Form/Admin/Type/LogSeverityChoiceType.php`
`1377`	`1377`
`1378`	`1378`	`-`
`@@ -1382,7 +1382,7 @@ parameters:`
`1382`	`1382`
`1383`	`1383`	`-`
`1384`	`1384`	`message: "#^Class Dispatcher is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1385`		`- count: 1`
	`1385`	`+ count: 2`
`1386`	`1386`	`path: src/PrestaShopBundle/Routing/LegacyRouterChecker.php`
`1387`	`1387`
`1388`	`1388`	`-`
`@@ -1420,6 +1420,11 @@ parameters:`
`1420`	`1420`	`count: 1`
`1421`	`1421`	`path: src/PrestaShopBundle/Twig/Component/AbstractMultistoreHeader.php`
`1422`	`1422`
	`1423`	`+ -`
	`1424`	`+ message: "#^Class Shop is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
	`1425`	`+ count: 2`
	`1426`	`+ path: src/PrestaShopBundle/Twig/Component/HeadTag.php`
	`1427`	`+`
`1423`	`1428`	`-`
`1424`	`1429`	`message: "#^Namespace AdminController is forbidden, No legacy calls inside the prestashop bundle\\. Please create an interface and an adapter if you need to\\.$#"`
`1425`	`1430`	`count: 1`