From 40b2111f4d676a96fbcbe270b546966aaa7d9b6e Mon Sep 17 00:00:00 2001
From: Andrey Tretyak <andreyt@microsoft.com>
Date: Mon, 10 Oct 2022 10:03:51 -0700
Subject: [PATCH] Add strong name signing (#2575)

---
 Directory.Build.props                             |   7 +++++++
 .../Octokit.Tests.Integration.csproj              |   1 +
 Octokit/Octokit.csproj                            |   5 +++++
 Octokit/Properties/AssemblyInfo.cs                |   3 ---
 build/Build.csproj                                |   1 +
 key.snk                                           | Bin 0 -> 596 bytes
 6 files changed, 14 insertions(+), 3 deletions(-)
 create mode 100644 Directory.Build.props
 delete mode 100644 Octokit/Properties/AssemblyInfo.cs
 create mode 100644 key.snk

diff --git a/Directory.Build.props b/Directory.Build.props
new file mode 100644
index 0000000000..c7568165b2
--- /dev/null
+++ b/Directory.Build.props
@@ -0,0 +1,7 @@
+<Project>
+  <PropertyGroup Label="Strong name signing">
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\key.snk</AssemblyOriginatorKeyFile>
+    <StrongNameSuffix>, PublicKey=0024000004800000940000000602000000240000525341310004000001000100f1e6b635f0c0b44c03d712e4f2cf789ddb54d7f74a9b34e2ece3aafb6afbfd46ec2b033f4104ef88f6afec226c5c647f453852ba3847fd9e37727c7dcb54e24731a288a107457a2c3e8b26ab04c25b206797be48cfe7a2b2c427422d0b0dd18c82111f21798f997e5d33ecc25c677744709c3785e0e650d6e0456a034a31acc4</StrongNameSuffix>
+  </PropertyGroup>
+</Project>
diff --git a/Octokit.Tests.Integration/Octokit.Tests.Integration.csproj b/Octokit.Tests.Integration/Octokit.Tests.Integration.csproj
index e39bcfe252..2f00a3dfe2 100644
--- a/Octokit.Tests.Integration/Octokit.Tests.Integration.csproj
+++ b/Octokit.Tests.Integration/Octokit.Tests.Integration.csproj
@@ -5,6 +5,7 @@
     <AssemblyTitle>Octokit.Tests.Integration</AssemblyTitle>
     <Authors>GitHub</Authors>
     <TargetFrameworks>net6.0;netcoreapp3.1;net462</TargetFrameworks>
+    <SignAssembly>false</SignAssembly>
     <NoWarn>$(NoWarn);CS4014;CS1998</NoWarn>
     <AssemblyName>Octokit.Tests.Integration</AssemblyName>
     <PackageId>Octokit.Tests.Integration</PackageId>
diff --git a/Octokit/Octokit.csproj b/Octokit/Octokit.csproj
index 33b13e2f7c..b212b79773 100644
--- a/Octokit/Octokit.csproj
+++ b/Octokit/Octokit.csproj
@@ -32,4 +32,9 @@
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
   </ItemGroup>
 
+  <ItemGroup Label="InternalsVisibleTo attributes">
+    <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
+      <_Parameter1>Octokit.Tests$(StrongNameSuffix)</_Parameter1>
+    </AssemblyAttribute>
+  </ItemGroup>
 </Project>
diff --git a/Octokit/Properties/AssemblyInfo.cs b/Octokit/Properties/AssemblyInfo.cs
deleted file mode 100644
index e783bcb861..0000000000
--- a/Octokit/Properties/AssemblyInfo.cs
+++ /dev/null
@@ -1,3 +0,0 @@
-using System.Runtime.CompilerServices;
-
-[assembly: InternalsVisibleTo("Octokit.Tests")]
\ No newline at end of file
diff --git a/build/Build.csproj b/build/Build.csproj
index 97efd74a08..0055bcf040 100644
--- a/build/Build.csproj
+++ b/build/Build.csproj
@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
+    <SignAssembly>false</SignAssembly>
     <TargetFramework>netcoreapp3.1</TargetFramework>
     <RunWorkingDirectory>$(MSBuildProjectDirectory)/..</RunWorkingDirectory>
   </PropertyGroup>
diff --git a/key.snk b/key.snk
new file mode 100644
index 0000000000000000000000000000000000000000..e85f2d4c92bc11acea21daddbf806293fbac9145
GIT binary patch
literal 596
zcmV-a0;~N80ssI2Bme+XQ$aES1ONa50098;=C(EPz_d&Q*AnFN&v>2NRM+=Pn>6C=
z<Er~=`~61jD+5141n-FUuk0dhTx5SmI8wSeNBy2Ra(sQuRN_Z5qKKgfMS3hgizcfC
z!doC`m%d2P=c2O2CqgX?4bhB(5g#FWkC}d5Gwi}#XLm$!oHvEw=1|t)MQQ^|F|5QR
zz<YF_5Llz}Ao)JgCM2Z`OVu2$-w6R%M${tVy6u(bP$?ejf~v=o-$MyUTtipiXzXah
z97P#AXf<^V(Sz38V+6cfq34N{9Pe7gCdcbwIspB$PXYFIy?kG-d4GKz6J1o;gKhNZ
z1|&fENjW+_?bScdrXqKKO60!33bpDnckBhjpe~^g0Hicuul0B5zqXxm?=mV7MEj1Z
z)0$sBq1j|9s2*YKd?rS7mppEe6+pwGt;DrH_E>YdY26h~CUT5WQ3-jrS&QgCIsW(!
zl3S}~n?AQ##)RU-ySzy%n?DsKJ15W#PdQ__tqVWC1jmas?b`@FZLr4zCCA=GYqbky
z<qBAGa`{c>9DB5aK68|_jFjsfov-JZ35fLZ5<#no8Ql4}_BzxF?mNUEnNtn1KJK7E
z4$=(In|d{cV`<i|+7F!EQ4OGN!Z<jGk15v`i!<Mu6#8YDnSW+QDmvhg8|KI};KajE
zwP1607~19x!t6>heGRD^#d&>kJMzz^FZOJC<Tb~EPg(c}8gR;T@cRT`c5?QWNHs=R
i%xmkE*js*O-y?S<No~$i%#dFHT6uRhSBJR}oFry*>>VHg

literal 0
HcmV?d00001