Remove misguided call to srand()

Michael Bunk · Michael Bunk · commit deec149ca363 · 2014-10-29T12:27:38.000+01:00
A random number generator needs to be initialized once per process after a fork, but not after each request, more so with an argument that changes only once per second. This fixes owasp-modsecurity#778
diff --git a/apache2/modsecurity.c b/apache2/modsecurity.c
@@ -223,8 +223,6 @@ static void modsecurity_persist_data(modsec_rec *msr) {
     }
 
     /* Remove stale collections. */
-    srand(time(NULL));
-
     if (rand() < RAND_MAX/100) {
         arr = apr_table_elts(msr->collections);
         te = (apr_table_entry_t *)arr->elts;

Original file line number	Diff line number	Diff line change
`@@ -223,8 +223,6 @@ static void modsecurity_persist_data(modsec_rec *msr) {`
`223`	`223`	`}`
`224`	`224`
`225`	`225`	`/* Remove stale collections. */`
`226`		`- srand(time(NULL));`
`227`		`-`
`228`	`226`	`if (rand() < RAND_MAX/100) {`
`229`	`227`	`arr = apr_table_elts(msr->collections);`
`230`	`228`	`te = (apr_table_entry_t *)arr->elts;`