-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spongeforge not working with Galacticraft 1.8.9 #2473
Comments
Sponge version? Is the problem resolved by installing PlayerAPI alongside Galacticraft? |
I tried to create a issue on spongeforge github, but it was closed with the message "1.8 is not supported". My forge version is the latest one "forge-1.8.9-11.15.1.1902-1.8.9-universal". And I am using build 45. I will also try to install playerapi later. EDIT: Playerapi didn't work. |
[18:29:28] [Client thread/INFO]: Setting user: candeniz |
This is what I wanted to see:
|
I've looked into this some more, seems like this is absolutely a SpongeForge issue. With Sponge 1.8.9 installed, this code:
returns null when it should return a Looking at their issues list, SpongeForge developers were aware of several issues with mods creating dimensions, and looks like they fixed it in SpongePowered/SpongeForge@f07f8a4 (maybe one or two commits earlier or later than that as well, I am not completely familiar with their code). But it looks like they made that fix in MC1.10.2 or later versions of SpongeForge only - what they call "bleeding" - and not 1.8.9. I don't really understand their policy on that, as that means that they are aware of a fixable issue in 1.8.9 which prevents Sponge from working with a number of mods. Your choices here may be limited to asking Sponge kindly to backport their fix to their 1.8.9 version, or waiting until we release a 1.10.2 version of Galacticraft which will not be for some time yet. |
The Sponge guys have pretty much said they will accept a Sponge patch from me to fix this in 1.8.9 so I will be looking at doing that over the next few days. I will post in this thread when it's ready for testing, but I'm not going to re-open this, because this is not a Galacticraft issue. By the way you should be looking at our build 51 for 1.8.9 beta, it's better than build 45. I'm not sure that there's public access to the beta but maybe you can get it from the same place you found build 45. |
No description provided.
The text was updated successfully, but these errors were encountered: