Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar command caching #441

Closed
alekm opened this issue Mar 24, 2022 · 3 comments
Closed

Solar command caching #441

alekm opened this issue Mar 24, 2022 · 3 comments
Labels
bug Something isn't working needs triage needs a priority assigned

Comments

@alekm
Copy link

alekm commented Mar 24, 2022

Bug description

Discord will cache images when produced from a URL, causing solar data images that can be days or weeks old.

Steps to reproduce

solar

Expected behaviour

Suspect serving an image the same way the svg images are gathered and producing with attachment:// would suffice with a realtime image instead of a cached image from the URL

How did you download qrm?

Git (clone)

How are you running qrm?

Docker

What qrm version are you running?

v2.7.4

Environment

No response

Logs

No response

Additional context, screenshots, etc

No response

@alekm alekm added bug Something isn't working needs triage needs a priority assigned labels Mar 24, 2022
@classabbyamp
Copy link
Member

this is a known issue: #322

Sending a file is not optimal, because the time spent uploading the image is blocking, which is not great, especially for large images.

@alekm
Copy link
Author

alekm commented Mar 24, 2022

Can this be fixed by adding a timecode to the url? (e.g. https://www.hamqsl.com/solarsun.php?t=1648097678)

@classabbyamp
Copy link
Member

hamqsl's images don't support giving any kind of timestamp in a way that affects the generated image (like the greyline map does), and adding a unique nonce just for discord doesn't work (see #308 and #318, especially #318 (comment)).

We've spent a while on this issue and the only reasonable solution seems to be making a small cdn/image proxy, which we haven't had time to implement yet.

@alekm alekm closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage needs a priority assigned
Projects
None yet
Development

No branches or pull requests

2 participants