You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The class DynamicModelGenerator defines a view static functions to generate configuration files.
It seems that these static functions are not necessarily have to be static, and that the static attribute can be removed.
Additionaly, the call of static function as a non-static function should be avoided.
The class ConfigGeneratorService for example uses an instance of class DynamicModelGenerator and call the method generateAutomaticTableConfigurationForModelClassName() non-static.
The other as static declared methods within class DynamicModelGenerator seems to be called internally and can be switched to non static methods.
The calls of these methods should be changed to non-static function calls.
The text was updated successfully, but these errors were encountered:
The class
DynamicModelGenerator
defines a view static functions to generate configuration files.It seems that these static functions are not necessarily have to be static, and that the
static
attribute can be removed.Additionaly, the call of static function as a non-static function should be avoided.
The class
ConfigGeneratorService
for example uses an instance of classDynamicModelGenerator
and call the methodgenerateAutomaticTableConfigurationForModelClassName()
non-static.See:
crossmedia_fourallportal/Classes/Service/ConfigGeneratorService.php
Line 50 in 3e00a60
The other as static declared methods within class
DynamicModelGenerator
seems to be called internally and can be switched to non static methods.The calls of these methods should be changed to non-static function calls.
The text was updated successfully, but these errors were encountered: