Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYPO3 12: TYPO3 locking strategy should be used #37

Open
3l73 opened this issue Sep 25, 2024 · 1 comment
Open

TYPO3 12: TYPO3 locking strategy should be used #37

3l73 opened this issue Sep 25, 2024 · 1 comment

Comments

@3l73
Copy link

3l73 commented Sep 25, 2024 •
edited
Loading

With TYPO3 9 the path var moved from typo3temp/var to the application root, which matches more the symfony standard.

Additionaly, the path locks was changed into lock.

crossmedia_fourallportal/Classes/Service/EventExecutionService.php

Line 516 in 7f2542c

return GeneralUtility::getFileAbsFileName('typo3temp/var/locks/') . 'lock_4ap_sync.lock';

TYPO3 itself offers functionality for locking, which should be used.

See:

ChangeLogs:
@3l73 3l73 changed the title TYPO3 12: Use var path from the environment TYPO3 12: Use TYPO3 lock strategy Oct 1, 2024
@3l73 3l73 changed the title TYPO3 12: Use TYPO3 lock strategy TYPO3 12: TYPO3 locking strategy should be used Oct 1, 2024
3l73 added a commit to dkd/crossmedia_fourallportal that referenced this issue Oct 1, 2024
@3l73
test: configure tests
bd699c5 
Add dependency to the TYPO3 testing framework in order to run unit and functional tests.

Increase version of phpunit to match the current version constraints.

Since no tests are currently available, this should not have any side effects.

Refs: mia3#37
3l73 added a commit to dkd/crossmedia_fourallportal that referenced this issue Oct 1, 2024
@3l73
test: event execution lock
6aa8189 
This test will verify the behaviour of the lock and unlock functionality.

Refs: mia3#37
@3l73 3l73 mentioned this issue Oct 1, 2024
Open
@3l73
Copy link
Author

3l73 commented Oct 1, 2024

The current pull request contains a test to verify the lock baviour based on the TYPO3 locking system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@3l73