Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to account for both 'datafile' and 'data file' #97

Closed
tashrifbillah opened this issue Jun 6, 2019 · 2 comments · Fixed by #103
Closed

Need to account for both 'datafile' and 'data file' #97

tashrifbillah opened this issue Jun 6, 2019 · 2 comments · Fixed by #103
Assignees

Comments

@tashrifbillah
Copy link
Contributor

We should account for both 'data file' and 'datafile' in Ln 190 and Ln 211 just like:
https://github.com/mhe/pynrrd/blob/master/nrrd/reader.py#L354

@addisonElliott
Copy link
Collaborator

:+1 I agree. Personally, I think the easiest option may be to choose one setup data file or datafile (I prefer data file personally) and then stick to it. Thus, have a line like:

if 'datafile' in self.header:
    self.header['data file'] = self.header.pop('datafile')

Then you can assume that there will only be a datafile. Just my initial thoughts.

@tashrifbillah
Copy link
Contributor Author

Assign: @tashrifbillah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants