Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release? #67

Closed
ihnorton opened this issue Sep 13, 2018 · 5 comments
Closed

Release? #67

ihnorton opened this issue Sep 13, 2018 · 5 comments

Comments

@ihnorton
Copy link
Contributor

Would it be possible to do a bump release to get the compression changes into PyPI? Thanks!

@ihnorton
Copy link
Contributor Author

ref #65

@addisonElliott
Copy link
Collaborator

Thank you for reminding me. My initial plan was to give it some time in case another PR was accepted. But then I forgot about it!

I released version 0.3.3. The PyPi badge on the README of this project still shows 0.3.2 but I think that it will automatically update.

@ihnorton
Copy link
Contributor Author

ihnorton commented Sep 13, 2018

Many thanks! cc @tashrifbillah FYI

@tashrifbillah
Copy link
Contributor

Kudos to @ihnorton! Previsouly writing nrrd file used to take ~95 seconds on a 32 processor machine. Now, after setting compression_level = 1, the same job takes only 3 seconds without any trade-off against space.

@addisonElliott
Copy link
Collaborator

That's great to hear.

If there are any other problems with the library (such as the performance issues you described), then it would help everyone out, including me, if you open an issue about the matter.

I'm happy to work on any issues with the library, but I need to know about them first. I don't use NRRD files a lot so I'm sure there are bugs/issues out there that are unknown to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants