Skip to content

Conversation

@davimed
Copy link

@davimed davimed commented Mar 10, 2025

Ensure that __get_disp_and_event_classes returns a tuple of three elements, as expected by WithEvents and DispatchWithEvents.

Ensure that __get_disp_and_event_classes returns a tuple of three elements, as expected by WithEvents and DispatchWithEvents
@davimed davimed marked this pull request as ready for review March 10, 2025 14:13
@mhammond
Copy link
Owner

@Avasam this is a regression from #2322?

@mhammond mhammond requested a review from Avasam March 12, 2025 01:10
@Avasam
Copy link
Collaborator

Avasam commented Mar 12, 2025

@Avasam this is a regression from #2322?

Yes.

This current PR duplicates the code of the non-if branch. Which was one of the point of splitting this off in a separate function in the first place.

See #2491 which produces the same fix without duplication.

@Avasam
Copy link
Collaborator

Avasam commented Mar 12, 2025

This should be fixed by #2491 😃

@Avasam Avasam closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants