Issue with null rows on fetch

[achang-s]

Hello,

I encountered an issue when processing an excel file with null rows (not empty rows) between valid rows. While NPOI knows the proper size of the sheet collection, the loop condition while (i <= MaxRowNumber && (row = sheet.GetRow(i)) != null) on line 420 of Fetch(ISheet sheet, Type type, Func<string, object, object> valueParser = null) stops looping through the collection if it hits a null row, even if there are more valid rows later on in the sheet.

This is because the index is still looping through the row keys rather than the collection's physical index, see image for reference, GetRow looks for 19 which is null and never proceeds to 19 the collection since its key is 22.

As a stopgap, in my application I preprocess the file by replacing these null rows with empty rows. Thanks.

[mganss]

Can you attach a sample Excel file?

[achang-s]

null_test.xlsx

Here is a sample file. Row 6 (collection index 5) appears blank but is a null row, the key that GetRow(i) uses is actually 7

Also, in the process of creating this test file, another potential issue came up, I believe I did something like deleting rows after the valid rows, and this generated other entries with a high value. In my own workaround pre-processing the file, I ended up using the sheet's GetRowEnumerator() to traverse the collection instead of row key.

[mganss]

Thanks. It's fixed in 5.1.253. Regarding the other issue, could you open a new issue and provide steps to repro?

[achang-s]

Thanks @mganss. It seems like the other issue I mentioned is no longer a problem now that the iterator is used and only iterates through the actual number of physically present rows. It was only problematic before because my previous preprocess method was also naively using the row key as an index to loop. Not sure why but on LibreOffice Calc deleting rows in a certain way (right click delete on rows existing in the middle of other valid rows, and selecting Delete entire row) would set the row number values of the later to rows to over 1,000,000 at least when viewed in NPOI's collection (this can be seen when inspecting in the debugger the aforementioned attached file).