fix: rewrite useBreakpoint #862
Conversation
|
I see it has failed a size limit by 8 bytes. Given how arbitrary the 1.18K limit seems, I'm going to assume you won't need me to find 8 bytes to trim. Do I increase the limit in package.json as part of this commit, or how do you want me to proceed? |
|
@tremby, нello! Thank you very much for the help! Yes, you can increase the limit. |
|
@tremby, sorry, I can't answer quickly right now. I am sick of covid-19. Today I will check everything during the day. To be clear, I have no experience with SSR and didn't even think about possible problems. |
## [9.0.6](v9.0.5...v9.0.6) (2020-12-05) ### Bug Fixes * rewrite useBreakpoint ([#862](#862)) ([3947016](3947016))
|
🎉 This PR is included in version 9.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Ouch; I wish you a speedy recovery. Thanks for merging this. Though it seems like I was too hasty when I said the problem was totally solved. Another pull request incoming... |
This changeset rewrites useBreakpoint and fixes #860.
The hook now returns either a boolean or
null;nullin the case wherewindowdoesn't exist and so whether or not the query matches is unknown. It now no longer sets aresizehandler onwindow, instead using thechangeevent of the media query list. This is much more efficient.I honestly don't know exactly what in the old version was causing the bug, but it's definitely fixed with this new version!
Note that I have never used Emotion, and have not tested the emotion version here. But given that the old version of the React one was identical to the old version of the Emotion one other than one of the require lines at the top, I expect it to be fine.