Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add strict types #1771

Merged
merged 3 commits into from
Feb 4, 2024
Merged

feat: 🎸 add strict types #1771

merged 3 commits into from
Feb 4, 2024

Conversation

mg901
Copy link
Owner

@mg901 mg901 commented Feb 4, 2024

BREAKING CHANGE: 🧨 remove StyledBreakpointsTheme & MediaQueries types

mg901 added 2 commits February 4, 2024 18:19
BREAKING CHANGE: 🧨 remove StyledBreakpointsTheme & MediaQueries types
Copy link

stackblitz bot commented Feb 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mg901 mg901 changed the title feat: add string types feat: add strict types Feb 4, 2024
@mg901 mg901 changed the title feat: add strict types feat: add strong types Feb 4, 2024
@mg901 mg901 changed the title feat: add strong types feat: 🎸 add strong types Feb 4, 2024
@mg901 mg901 changed the title feat: 🎸 add strong types feat: 🎸 add strict types Feb 4, 2024
@mg901 mg901 merged commit 281cc60 into master Feb 4, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 4, 2024
# [13.0.0](v12.1.10...v13.0.0) (2024-02-04)

### Features

*  🎸 add strict types ([#1771](#1771)) ([281cc60](281cc60))

### BREAKING CHANGES

* 🧨 remove StyledBreakpointsTheme & MediaQueries types

* build: add `semantic-release-githubsquash` plugin
Copy link

github-actions bot commented Feb 4, 2024

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mg901 mg901 deleted the feat/v13 branch February 4, 2024 17:52
@mroswald
Copy link

mroswald commented Feb 5, 2024

This introduced a regression in useMediaQuery.js. The signature of addListener is different to addEventListener and was called correctly before.

mediaQueryList[listenerMethod]('change', handleChange);

Should I open an issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants