Skip to content

Fix MA0185 false-positive for nullable value types #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meziantou merged 4 commits into from
Feb 3, 2026
+48 −1
Merged

Fix MA0185 false-positive for nullable value types #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72d5d46
Initial plan
Copilot Feb 3, 2026
9945d85
Fix MA0185 false-positive with nullable types like int?
Copilot Feb 3, 2026
cdb837f
Add additional test for nullable double to ensure comprehensive coverage
Copilot Feb 3, 2026
e2c59fe
Fix: Use UnwrapNullableOfT option in MA0185 instead of modifying IsFo…
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...iantou.Analyzer/Rules/SimplifyStringCreateWhenAllParametersAreCultureInvariantAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ private static void AnalyzeInvocation(OperationAnalysisContext context, IMethodS
if (interpolatedStringArgument is IInterpolatedStringHandlerCreationOperation handlerCreation)
{
var interpolatedStringContent = handlerCreation.Content;
if (!cultureSensitiveContext.IsCultureSensitiveOperation(interpolatedStringContent, CultureSensitiveOptions.None))
// Use UnwrapNullableOfT to check the underlying type of nullable types
if (!cultureSensitiveContext.IsCultureSensitiveOperation(interpolatedStringContent, CultureSensitiveOptions.UnwrapNullableOfT))
{
context.ReportDiagnostic(Rule, operation);
}
Expand Down
46 changes: 46 additions & 0 deletions ...lyzer.Test/Rules/SimplifyStringCreateWhenAllParametersAreCultureInvariantAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,52 @@ await CreateProjectBuilder()
.ValidateAsync();
}

[Fact]
public async Task StringCreateWithInvariantCulture_WithNullableInteger_NoDiagnostic()
{
const string SourceCode = """
using System;
using System.Globalization;

class TypeName
{
public void Test()
{
int? n = 42;
var s = string.Create(CultureInfo.InvariantCulture, $"/v{n}");
}
}
""";
await CreateProjectBuilder()
.WithLanguageVersion(Microsoft.CodeAnalysis.CSharp.LanguageVersion.CSharp10)
.WithTargetFramework(TargetFramework.Net6_0)
.WithSourceCode(SourceCode)
.ValidateAsync();
}

[Fact]
public async Task StringCreateWithInvariantCulture_WithNullableDouble_NoDiagnostic()
{
const string SourceCode = """
using System;
using System.Globalization;

class TypeName
{
public void Test()
{
double? value = 3.14;
var s = string.Create(CultureInfo.InvariantCulture, $"Value: {value}");
}
}
""";
await CreateProjectBuilder()
.WithLanguageVersion(Microsoft.CodeAnalysis.CSharp.LanguageVersion.CSharp10)
.WithTargetFramework(TargetFramework.Net6_0)
.WithSourceCode(SourceCode)
.ValidateAsync();
}

[Fact]
public async Task StringCreateWithInvariantCulture_EmptyString_ShouldReport()
{
Expand Down