From 21e64bf9e4d227d93dd86a3da26b0e6e22cb8302 Mon Sep 17 00:00:00 2001 From: Stuart Turner Date: Sun, 8 Mar 2026 20:31:32 -0500 Subject: [PATCH 1/5] Add `roslyn5.0` packing --- .github/workflows/ci.yml | 3 +++ src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj | 3 +++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f0c69f600..37dc66a30 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -81,6 +81,9 @@ jobs: - run: dotnet build src/Meziantou.Analyzer/Meziantou.Analyzer.csproj --configuration Release /p:RoslynVersion=roslyn4.14 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.roslyn4.14.binlog - run: dotnet build src/Meziantou.Analyzer.CodeFixers/Meziantou.Analyzer.CodeFixers.csproj --configuration Release /p:RoslynVersion=roslyn4.14 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.CodeFixers.roslyn4.14.binlog + - run: dotnet build src/Meziantou.Analyzer/Meziantou.Analyzer.csproj --configuration Release /p:RoslynVersion=roslyn5.0 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.roslyn4.14.binlog + - run: dotnet build src/Meziantou.Analyzer.CodeFixers/Meziantou.Analyzer.CodeFixers.csproj --configuration Release /p:RoslynVersion=roslyn5.0 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.CodeFixers.roslyn5.0.binlog + - run: dotnet restore src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj -bl:Meziantou.Analyzer.Pack.restore.binlog - run: dotnet pack src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj --configuration Release --no-build /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.Pack.pack.binlog - run: dotnet pack src/Meziantou.Analyzer.Annotations/Meziantou.Analyzer.Annotations.csproj --configuration Release /bl:Meziantou.Analyzer.Annotations.pack.binlog diff --git a/src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj b/src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj index e906affbb..326956712 100644 --- a/src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj +++ b/src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj @@ -37,5 +37,8 @@ + + + \ No newline at end of file From cf1d3abcb9ea12a997ac4d706f68c92f8ef8a572 Mon Sep 17 00:00:00 2001 From: Stuart Turner Date: Mon, 9 Mar 2026 08:14:39 -0500 Subject: [PATCH 2/5] Update .github/workflows/ci.yml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Gérald Barré --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 37dc66a30..e700a7a70 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -81,7 +81,7 @@ jobs: - run: dotnet build src/Meziantou.Analyzer/Meziantou.Analyzer.csproj --configuration Release /p:RoslynVersion=roslyn4.14 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.roslyn4.14.binlog - run: dotnet build src/Meziantou.Analyzer.CodeFixers/Meziantou.Analyzer.CodeFixers.csproj --configuration Release /p:RoslynVersion=roslyn4.14 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.CodeFixers.roslyn4.14.binlog - - run: dotnet build src/Meziantou.Analyzer/Meziantou.Analyzer.csproj --configuration Release /p:RoslynVersion=roslyn5.0 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.roslyn4.14.binlog + - run: dotnet build src/Meziantou.Analyzer/Meziantou.Analyzer.csproj --configuration Release /p:RoslynVersion=roslyn5.0 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.roslyn5.0.binlog - run: dotnet build src/Meziantou.Analyzer.CodeFixers/Meziantou.Analyzer.CodeFixers.csproj --configuration Release /p:RoslynVersion=roslyn5.0 /p:Version=${{ needs.compute_package_version.outputs.package_version }} /bl:Meziantou.Analyzer.CodeFixers.roslyn5.0.binlog - run: dotnet restore src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj -bl:Meziantou.Analyzer.Pack.restore.binlog From f1155c0c91dffc09d1037bda96c964410ae7e39e Mon Sep 17 00:00:00 2001 From: Stuart Turner Date: Mon, 9 Mar 2026 08:34:07 -0500 Subject: [PATCH 3/5] One more missed `5.0` --- src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj b/src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj index 326956712..6181ab5ef 100644 --- a/src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj +++ b/src/Meziantou.Analyzer.Pack/Meziantou.Analyzer.Pack.csproj @@ -39,6 +39,6 @@ - + \ No newline at end of file From b790281e291a84561f38565f68bef5bd975c0586 Mon Sep 17 00:00:00 2001 From: Stuart Turner Date: Mon, 9 Mar 2026 08:58:30 -0500 Subject: [PATCH 4/5] Add explicit `roslyn5.0` target --- Directory.Build.targets | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Directory.Build.targets b/Directory.Build.targets index 6c3714700..e6e28bac2 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -72,6 +72,19 @@ + + + + + + + + $(DefineConstants);ROSLYN5_0;ROSLYN_4_2_OR_GREATER;ROSLYN_4_4_OR_GREATER;ROSLYN_4_5_OR_GREATER;ROSLYN_4_6_OR_GREATER;ROSLYN_4_8_OR_GREATER;ROSLYN_4_10_OR_GREATER;ROSLYN_4_14_OR_GREATER;ROSLYN_5_0_OR_GREATER + $(DefineConstants);CSHARP9_OR_GREATER;CSHARP10_OR_GREATER;CSHARP11_OR_GREATER;CSHARP12_OR_GREATER;CSHARP13_OR_GREATER;CSHARP14_OR_GREATER + $(NoWarn);CS0618 + + + From f448df66fe748e5e3cda24fcc6d04306d9e5f42d Mon Sep 17 00:00:00 2001 From: Stuart Turner Date: Mon, 9 Mar 2026 09:24:58 -0500 Subject: [PATCH 5/5] Once more unto the breach dear friends --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e700a7a70..443f9a632 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -137,7 +137,7 @@ jobs: matrix: runs-on: [ ubuntu-latest ] configuration: [ Release ] - roslyn-version: [ 'roslyn4.2', 'roslyn4.4', 'roslyn4.6', 'roslyn4.8', 'roslyn4.14', 'default' ] + roslyn-version: [ 'roslyn4.2', 'roslyn4.4', 'roslyn4.6', 'roslyn4.8', 'roslyn4.14', 'roslyn5.0', 'default' ] fail-fast: false steps: - uses: actions/checkout@v4