[API] keep tags attached to previous subscribers #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry my english is not good!
I often have to work through the API and there are a few things that I feel need to be more suitable.
I don't see an api capable of creating new subscribers in bulk using the API (I'm ready to pr)
I proceed to create this API in the job queue, it's ok!
But job-queue can't return new subscriber list immediately so I can use API
POST /api/v1/tags/{tagId}/subscribers
I proceed to add subscribers based on your api service but your tags sync default configuration will delete previously attached user tags, so I had to rewrite the service completely new just different configuration as below .
My PR is default false when sync tags but you can enable the option with config.