Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] keep tags attached to previous subscribers #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmtung144
Copy link

Sorry my english is not good!

I often have to work through the API and there are a few things that I feel need to be more suitable.
I don't see an api capable of creating new subscribers in bulk using the API (I'm ready to pr)
I proceed to create this API in the job queue, it's ok!
But job-queue can't return new subscriber list immediately so I can use API POST /api/v1/tags/{tagId}/subscribers

I proceed to add subscribers based on your api service but your tags sync default configuration will delete previously attached user tags, so I had to rewrite the service completely new just different configuration as below .

My PR is default false when sync tags but you can enable the option with config.

@JonoB
Copy link
Contributor

JonoB commented Sep 27, 2022

The problem with this implementation is that there is now no way to actually remove tags from a subscriber.

@Seb33300
Copy link

Seb33300 commented Oct 3, 2024

This feature is now supported in V2 right?
https://sendportal.io/docs/v2/api/tag-subscribers#update

If you want to assign a tag to additional subscribers without removing existing ones, you should use the Store endpoint.

Use the POST endpoint to add new subscribers and PUT endpoint to replace all subscribers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants