From ea7205c217878d469ce963d5d8a5d17bbef42e7c Mon Sep 17 00:00:00 2001 From: Lucas Kent Date: Tue, 5 Jul 2022 12:50:33 +1000 Subject: [PATCH 1/2] Document CI enforced msrv in readme and rust-version fields --- README.md | 5 +++++ metrics-benchmark/Cargo.toml | 1 + metrics-exporter-prometheus/Cargo.toml | 1 + metrics-exporter-tcp/Cargo.toml | 1 + metrics-macros/Cargo.toml | 1 + metrics-observer/Cargo.toml | 1 + metrics-tracing-context/Cargo.toml | 1 + metrics-util/Cargo.toml | 1 + metrics/Cargo.toml | 1 + tooling/metrics-histogram-fidelity/Cargo.toml | 1 + 10 files changed, 14 insertions(+) diff --git a/README.md b/README.md index 144ee857..1c10cf3e 100644 --- a/README.md +++ b/README.md @@ -64,6 +64,11 @@ As well, there are also some community-maintained exporters and other integratio * [`metrics-exporter-newrelic`][metrics-exporter-newrelic]: A `metrics`-compatible exporter for sending metrics to New Relic. * [`opinionated_metrics`][opinionated-metrics]: Opinionated interface to emitting metrics for CLi/server applications, based on `metrics`. +## MSRV + +Minimum Supported Rust version is **1.56.1** +It is enforced in CI. + # contributing To those of you who have already contributed to `metrics` in some way, shape, or form: **a big, and continued, "thank you!"** ❤️ diff --git a/metrics-benchmark/Cargo.toml b/metrics-benchmark/Cargo.toml index c4b0adc7..8bbdb876 100644 --- a/metrics-benchmark/Cargo.toml +++ b/metrics-benchmark/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics-benchmark" version = "0.1.1-alpha.5" authors = ["Toby Lawrence "] edition = "2018" +rust-version = "1.56.1" publish = false [dependencies] diff --git a/metrics-exporter-prometheus/Cargo.toml b/metrics-exporter-prometheus/Cargo.toml index a5c50d1a..77ffc934 100644 --- a/metrics-exporter-prometheus/Cargo.toml +++ b/metrics-exporter-prometheus/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics-exporter-prometheus" version = "0.10.0" authors = ["Toby Lawrence "] edition = "2018" +rust-version = "1.56.1" license = "MIT" diff --git a/metrics-exporter-tcp/Cargo.toml b/metrics-exporter-tcp/Cargo.toml index 312a079f..34909bb1 100644 --- a/metrics-exporter-tcp/Cargo.toml +++ b/metrics-exporter-tcp/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics-exporter-tcp" version = "0.6.0" authors = ["Toby Lawrence "] edition = "2018" +rust-version = "1.56.1" license = "MIT" diff --git a/metrics-macros/Cargo.toml b/metrics-macros/Cargo.toml index 804ffac3..7a35397d 100644 --- a/metrics-macros/Cargo.toml +++ b/metrics-macros/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics-macros" version = "0.5.1" authors = ["Toby Lawrence "] edition = "2018" +rust-version = "1.56.1" license = "MIT" diff --git a/metrics-observer/Cargo.toml b/metrics-observer/Cargo.toml index b11ee514..6216e559 100644 --- a/metrics-observer/Cargo.toml +++ b/metrics-observer/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics-observer" version = "0.1.1-alpha.2" authors = ["Toby Lawrence "] edition = "2018" +rust-version = "1.56.1" publish = false license = "MIT" diff --git a/metrics-tracing-context/Cargo.toml b/metrics-tracing-context/Cargo.toml index cb481ae3..808c97cf 100644 --- a/metrics-tracing-context/Cargo.toml +++ b/metrics-tracing-context/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics-tracing-context" version = "0.11.0" authors = ["MOZGIII "] edition = "2018" +rust-version = "1.56.1" license = "MIT" diff --git a/metrics-util/Cargo.toml b/metrics-util/Cargo.toml index c1d61e2a..70ef2c2e 100644 --- a/metrics-util/Cargo.toml +++ b/metrics-util/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics-util" version = "0.13.0" authors = ["Toby Lawrence "] edition = "2018" +rust-version = "1.56.1" license = "MIT" diff --git a/metrics/Cargo.toml b/metrics/Cargo.toml index 4d9cec06..880c18ea 100644 --- a/metrics/Cargo.toml +++ b/metrics/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics" version = "0.19.0" authors = ["Toby Lawrence "] edition = "2018" +rust-version = "1.56.1" license = "MIT" diff --git a/tooling/metrics-histogram-fidelity/Cargo.toml b/tooling/metrics-histogram-fidelity/Cargo.toml index 28fe8f13..bd6850f1 100644 --- a/tooling/metrics-histogram-fidelity/Cargo.toml +++ b/tooling/metrics-histogram-fidelity/Cargo.toml @@ -3,6 +3,7 @@ name = "metrics-histogram-fidelity" version = "0.1.0" authors = ["Toby Lawrence "] edition = "2018" +rust-version = "1.56.1" [workspace] From fc97bce77a2e6f1dcbafc2c2cd95ff6aa57acd57 Mon Sep 17 00:00:00 2001 From: Lucas Kent Date: Wed, 6 Jul 2022 10:48:09 +1000 Subject: [PATCH 2/2] review feedback --- README.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 1c10cf3e..cf7500e1 100644 --- a/README.md +++ b/README.md @@ -66,9 +66,15 @@ As well, there are also some community-maintained exporters and other integratio ## MSRV -Minimum Supported Rust version is **1.56.1** +Minimum Supported Rust version is **1.56.1**. It is enforced in CI. +### policy for bumping MSRV + +* The last 4 stable releases must always be supported +* Goal is to try and support older versions where possible (not opting in to newer versions just to use a new helper method on standard library types, etc) +* Do not bump the MSRV for newer versions of dependencies in core crates (metrics and metrics-util) + # contributing To those of you who have already contributed to `metrics` in some way, shape, or form: **a big, and continued, "thank you!"** ❤️