Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile tree dot notation #592

Open
akvlad opened this issue Oct 21, 2024 · 0 comments
Open

profile tree dot notation #592

akvlad opened this issue Oct 21, 2024 · 0 comments

Comments

@akvlad
Copy link
Collaborator

akvlad commented Oct 21, 2024

What

Implement dot notation for profile trees.

Why

#576 this particular bug happens because the "Explain" button requires "dot" notation which is not implemented.

How

Dot notation is a human-readable graph representation
https://en.wikipedia.org/wiki/DOT_(graph_description_language)
https://graphviz.org/doc/info/lang.html

The pyrosope implementation of dot is located in https://github.com/grafana/pyroscope/tree/main/pkg/frontend/dot/graph .
An example of a dot graph: example_gv.txt
Description of a graph: https://github.com/google/pprof/blob/main/doc/README.md#graphical-reports
Online dot graph viewer: https://dreampuf.github.io/GraphvizOnline/

For now let's omit

  • coloring
  • dotted lines

And implement the tree rendering method of a profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant