New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event should fire on `keydown`, not `keyup` #18

Open

metonym opened this issue Dec 3, 2023 · 0 comments

Assignees

Owner

metonym commented Dec 3, 2023 •

edited

Loading

There's a subtle, rather significant, UX difference between the two.

The event should fire on keydown and not on the keyup event.

E.g.,

if (
  document.activeElement instanceof HTMLInputElement ||
  document.activeElement instanceof HTMLTextAreaElement
) {
  // Exit early if an inputtable element is already focused.
  return;
}

if ((e.metaKey && e.key === 'k') || e.key === '/') {
  e.preventDefault();
  // Fire matching event
}

metonym self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment