Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments given in VarWebScaleAndColormap may not be going through pydantic #1291

Open
lewisblake opened this issue Jul 30, 2024 · 2 comments
Labels
bug 🐛 Something isn't working

Comments

@lewisblake
Copy link
Member

lewisblake commented Jul 30, 2024

Describe the bug

There are two __init__ methods in this class. Only the second one is being used. This means that the pydantic checking is not being used. One way to test this is to try and give VarWebScaleAndColormap arguments which are not scale and colmap

  • Pyaerocom version: 0.21.dev0
  • Computing platform: All
  • Configuration file (if applicable): NA
  • Error message (if applicable): NA

Relevant PR: #1256

@lewisblake lewisblake added the bug 🐛 Something isn't working label Jul 30, 2024
@lewisblake
Copy link
Member Author

lewisblake commented Jul 30, 2024

They aren't being passed correctly. Pydantic should've yelled at me:

from pyaerocom.aeroval.glob_defaults import VarWebScaleAndColormap
test = VarWebScaleAndColormap({"blah": {"blah": ["a", "b", "c"], "blub": ["d", "e", "f"]}})

@lewisblake lewisblake mentioned this issue Aug 9, 2024
9 tasks
@lewisblake
Copy link
Member Author

@heikoklein just want to put this on your radar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant