Fix coupon URL in notifications

Author: phylor

app/services/ops/coupon/expiration/notify.rb

@@ -4,8 +4,6 @@ module Ops
   module Coupon
     module Expiration
       class Notify
-        include Rails.application.routes.url_helpers
-
         attr_reader :coupon
 
         delegate :user, to: :coupon
@@ -30,11 +28,10 @@ def template_options
             "code" => coupon.code,
             "description" => coupon.description,
             "valid_until" => coupon.valid_until.present? ? I18n.l(coupon.valid_until) : "",
-            "url" => coupon_url(
+            "url" => Rails.application.routes.url_helpers.coupon_url(
               user.locale,
               coupon,
-              host: Rails.application.config.action_controller.default_url_options[:host],
-              port: Rails.application.config.action_controller.default_url_options[:port]
+              **Rails.application.config.action_controller.default_url_options
             )
           }
         end

config/application.rb

@@ -43,7 +43,11 @@ class Application < Rails::Application
     I18n.available_locales = %i[en]
     I18n.default_locale = :en
 
-    config.action_mailer.default_url_options = {host: ENV.fetch("HOST", "localhost"), port: 443}
+    config.action_mailer.default_url_options = {
+      host: ENV.fetch("HOST", "localhost"),
+      port: 443,
+      protocol: :https
+    }
     config.action_controller.default_url_options = config.action_mailer.default_url_options
   end
 end

config/environments/development.rb

@@ -76,4 +76,5 @@
   config.action_controller.raise_on_missing_callback_actions = true
 
   config.action_controller.default_url_options[:port] = 3000
+  config.action_controller.default_url_options[:protocol] = :http
 end