-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is gathering all text being generated appropriate #132
Comments
Telemetry is optional. You can set |
(The text is useful for us to debug errors folks are facing, etc, but if more people complain we can look into options... fyi @sidroopdaska) |
Still will have to patch it out, taking the "text" is just weird - what if we put sensitive business numbers with our company name or user information through this? It shouldn't leave the network "anonymized" or otherwise. |
@vatsalaggarwal I really don't see how collecting the text can help "debug errors" |
sure thing @MethanJess & @turtle0x1. I'll add a flag to avoid telemetry altogether. Will share a PR tomorrow. |
This should be disabled by default, not an "opt out" option that is not mentioned anywhere in the main README of the repo. |
@sidroopdaska any updates? |
It seems gathering all user input text is now be gathered as of this commit? eebdcc6
Adding analytics is annoying because we'll have to patch them out / add more firewall rules, but siphoning off user data like this feels very wrong if I've understood it correctly.
This could leak sensitive business information if meta voice was used as part of some kind of internal system, please considere adding a
--disable-metrics
flag/env or removing the gathering of input text altogether (the other stuff is "by the by" - if you just want trends you shouldn't need "text").The text was updated successfully, but these errors were encountered: