fix: Properly terminate origin regex with $ #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
approved these changes
Jul 12, 2024
FrederikBolding
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2576 +/- ##
=======================================
Coverage 93.99% 93.99%
=======================================
Files 459 459
Lines 9647 9647
Branches 1480 1480
=======================================
Hits 9068 9068
Misses 579 579 ☔ View full report in Codecov by Sentry. |
danjm
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jul 15, 2024
## **Description** This adds a patch for MetaMask/snaps#2576, which fixes a security issue in the origin validation in Snaps. [](https://codespaces.new/MetaMask/metamask-extension/pull/25823?quickstart=1)
](https://codespaces.new/MetaMask/metamask-extension/pull/25823?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight in the regex generation for
allowedOriginsthat allows a bypass of the functionality due to the regex not being properly terminated.Also fixes a mistake in the regex generation that wouldn't properly add
.*to the regex but instead use somewhat escaped characters.