You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Something changed between nightly-2023-03-29 (our current version) and nightly-2023-05-23 that breaks some of our const trait implementations.
If you try to cargo check with a newer version (the latest working I've tested was nightly-04-15, but I'm not sure if this is the last working one or something more recent also works) you'll get a #[const_trait] error.
Steps to Reproduce
Update rust-toolchain.toml to nightly-2023-05-23;
Run cargo check;
sadness;
Backtrace
error: const `impl`for trait `Default` which is not marked with `#[const_trait]`
--> mirrord/layer/src/detour.rs:114:15
|
114 | impl<T> const Default for HookFn<T> {
| ^^^^^^^
|
= note: marking a trait with `#[const_trait]` ensures all default method bodies are `const`
= note: adding a non-const method body in the future would be a breaking change
Relevant Logs
No response
Your operating system and version
linux
Local process
NA
Local process version
No response
Additional Info
P.S. You'll probably get an error in the protocol/file.rs and not on the layer crate. In protocol the issue is easy to solve, we could just drop the const trait implementation, but in layer it requires bigger changes, due to HookFn expecting const stuff.
The text was updated successfully, but these errors were encountered:
Bug Description
Something changed between
nightly-2023-03-29
(our current version) andnightly-2023-05-23
that breaks some of our const trait implementations.If you try to
cargo check
with a newer version (the latest working I've tested wasnightly-04-15
, but I'm not sure if this is the last working one or something more recent also works) you'll get a#[const_trait]
error.Steps to Reproduce
rust-toolchain.toml
tonightly-2023-05-23
;cargo check
;Backtrace
Relevant Logs
No response
Your operating system and version
linux
Local process
NA
Local process version
No response
Additional Info
P.S. You'll probably get an error in the
protocol/file.rs
and not on thelayer
crate. Inprotocol
the issue is easy to solve, we could just drop the const trait implementation, but inlayer
it requires bigger changes, due toHookFn
expecting const stuff.The text was updated successfully, but these errors were encountered: