Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BeforeRunTaskProvider for Tomcat #230

Closed
t4lz opened this issue Jan 9, 2024 · 2 comments
Closed

Use BeforeRunTaskProvider for Tomcat #230

t4lz opened this issue Jan 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@t4lz
Copy link
Member

t4lz commented Jan 9, 2024

We asked for it here: https://youtrack.jetbrains.com/issue/IDEA-342485/Expose-a-Tomcat-RunConfigurationExtension

currently there isn't one so we have an ExecutionListener for Tomcat where we have to detect Tomcat runs by the dynamic type of the configuration.

@t4lz t4lz added the enhancement New feature or request label Jan 9, 2024
@eyalb181
Copy link
Member

Hey @t4lz , @Razz4780 I saw you discussed this in the JetBrains issue tracker - can this issue be closed?

@t4lz t4lz changed the title Use Tomcat RunConfigurationExtension once it exists Use BeforeRunTaskProvider for Tomcat Jun 20, 2024
@t4lz
Copy link
Member Author

t4lz commented Jun 20, 2024

Hey @t4lz , @Razz4780 I saw you discussed this in the JetBrains issue tracker - can this issue be closed?

Updated issue title and comment. @aviramha asked me to open this issue because our detection of Tomcat runs is a bit weird. JetBrains provided an existing solution, what we asked for isn't necessary. @Razz4780 said we can use BeforeRunTaskProvider for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants