Improve scale-in and node reuse feature tests#663
Conversation
metal3-io-bot
added
the
size/M
|
/test-features |
furkatgofurov7
force-pushed
the
follow-up-to-633/furkat
branch
from
ecc711f to
6018fef
Compare
|
/test-features |
furkatgofurov7
force-pushed
the
follow-up-to-633/furkat
branch
from
6018fef to
890dc63
Compare
|
/test-features |
fmuyassarov
left a comment
fmuyassarov
left a comment
There was a problem hiding this comment.
LGTM. Would you mind to rename the PR tile, and instead mention that this is follow-up in the description?
|
/retitle Improve scale-in and node reuse feature tests |
metal3-io-bot
changed the title
Yes sure, done. |
|
/test-centos-integration |
furkatgofurov7
force-pushed
the
follow-up-to-633/furkat
branch
from
890dc63 to
5d2d1f9
Compare
|
/test-features |
|
/test-centos-integration |
|
This looks good to me |
There was a problem hiding this comment.
/approve
We should probably replace all the K8S related shelling with filter plugins that @macaptain suggested.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmuyassarov, furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
5 participants
Follow up for improving #633 as per discussion. Names in the task has been improved to indicate start & end of the each test to make a debugging feature test easier in the future.