Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPA download fails to handle image file names with dot ».« #62

Open
fhaftmann opened this issue Jan 7, 2025 · 2 comments
Open

IPA download fails to handle image file names with dot ».« #62

fhaftmann opened this issue Jan 7, 2025 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@fhaftmann
Copy link

The MR 2d513ad unfortunately introduces a breakdown: whenever an image file name contains a dot ».«, everything beyond this dot is considered as file name extension.

This may be valid for something like image.tar.gz, but breaks down as soon as the name itself contains a dot, e.g. due to a versioned image name like image-v0.1.2.tar.gz.

Possible solutions:

  • Select suitable image file extension from a list of candidates.
  • As soon as an image file extension is provided explicitly via environment, make no attempt to guess a file extension.
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Jan 7, 2025
@dtantsur
Copy link
Member

dtantsur commented Jan 7, 2025

/triage accepted
/kind bug
/cc @Rozzii

Adam, PTAL. Maybe we actually should rewrite the whole thing in Python or Go?

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jan 7, 2025
@Rozzii
Copy link
Member

Rozzii commented Jan 7, 2025

I will go with option 2 for now and then we could rewrite it in something else but I am not keen on doing that.

@Rozzii Rozzii self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants