Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make components render by default #92

Closed
natecavanaugh opened this issue Apr 16, 2015 · 4 comments
Closed

Make components render by default #92

natecavanaugh opened this issue Apr 16, 2015 · 4 comments
Labels

Comments

@natecavanaugh
Copy link

I'm proposing we do away with requiring the render call manually, unless someone passes render: false as part of the config.

With YUI, in 90% of the cases, when we instantiated the component was also when we wanted to render it.
So my proposal would end up looking like:

let myCmp1 = new MyComponent({}); //renders component

let myCmp2 = new MyComponent({ render: false });
// do some work ...
myCmp.render();

What do you guys think?

@zenorocha
Copy link
Contributor

Oh, I agree with that. Today, I forgot to do that.

@yuchi
Copy link
Contributor

yuchi commented Apr 17, 2015

I'd be happy to loose that «oh yeah, I need to render it» moment.

@eduardolundgren
Copy link
Contributor

SGTM. We can handle this improvement next week. Feel free to send pull request to it :)

@mairatma
Copy link
Contributor

mairatma commented May 2, 2016

It took longer than a week, but we did this change now, creating a component now also renders it by default :)

@mairatma mairatma closed this as completed May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants