Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metal-useragent] User Agent is not being detected since v2.2.0 #382

Closed
antonio-ortega opened this issue Jun 5, 2018 · 2 comments
Closed

[metal-useragent] User Agent is not being detected since v2.2.0 #382

antonio-ortega opened this issue Jun 5, 2018 · 2 comments

Comments

@antonio-ortega
Copy link

Hi,

User Agent is not being detected for any browser in version 2.2.0. It is working properly if I downgrade the package to 2.1.3.

As far as I know, it looks like the changes introduced here are the root cause of this issue, since we were assigning window to UA.globals.window and now we're assigning window to UA.globals.

Thanks,
@gcmznt gcmznt mentioned this issue Jun 5, 2018
Merged
@diegonvs diegonvs mentioned this issue Jun 5, 2018
Closed
@diegonvs
Copy link
Contributor

diegonvs commented Jun 5, 2018 •
edited
Loading

Hey @antonio-ortega, metal-useragent is now in https://github.com/metal/metal-plugins/. I have filed an issue for you at it.

@jbalsas
Copy link
Contributor

jbalsas commented Jun 5, 2018

Sorry, that was my fault, I forgot :(

Closing here. See also that @gcmznt sent a fix to metal/metal-plugins#68

@jbalsas jbalsas closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbalsas @diegonvs @antonio-ortega