Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run tests #247

Closed
julien opened this issue Jun 13, 2017 · 5 comments
Closed

Unable to run tests #247

julien opened this issue Jun 13, 2017 · 5 comments

Comments

@julien
Copy link
Contributor

julien commented Jun 13, 2017

Hi,

Currently the test task is failing with version 2.13.0.

This happens with node v6.1.0 & npm 3.8.6 as well as node v8.1.0& npm 5.0.3.

Here is the output after running npm t for the command line.

13 06 2017 09:44:57.316:ERROR [framework.browserify]: bundle error
13 06 2017 09:44:57.319:ERROR [framework.browserify]: Error: Cannot find module 'metal-dom' from '/Users/jc/Documents/work/metal.js/packages/metal-component/test'
13 06 2017 09:44:57.331:INFO [karma]: Karma v1.7.0 server started at http://0.0.0.0:9876/
13 06 2017 09:44:57.331:INFO [launcher]: Launching browser Chrome with unlimited concurrency
13 06 2017 09:44:57.339:INFO [launcher]: Starting browser Chrome
13 06 2017 09:44:57.349:ERROR [framework.browserify]: bundle error
13 06 2017 09:44:57.349:ERROR [framework.browserify]: Error: Cannot find module 'incremental-dom-string' from '/Users/jc/Documents/work/metal.js/packages/metal-incremental-dom/src'
13 06 2017 09:44:57.349:ERROR [framework.browserify]: bundle error
13 06 2017 09:44:57.349:ERROR [framework.browserify]: Error: Cannot find module 'incremental-dom-string' from '/Users/jc/Documents/work/metal.js/packages/metal-incremental-dom/lib'
13 06 2017 09:44:57.352:ERROR [framework.browserify]: bundle error
13 06 2017 09:44:57.352:ERROR [framework.browserify]: Error: Cannot find module 'metal-dom' from '/Users/jc/Documents/work/metal.js/packages/metal-component/test/events'
13 06 2017 09:44:57.352:ERROR [framework.browserify]: bundle error
13 06 2017 09:44:57.352:ERROR [framework.browserify]: Error: Cannot find module 'metal-dom' from '/Users/jc/Documents/work/metal.js/packages/metal-component/src'
13 06 2017 09:44:57.354:ERROR [framework.browserify]: bundle error
13 06 2017 09:44:57.354:ERROR [framework.browserify]: Error: Cannot find module 'metal-dom' from '/Users/jc/Documents/work/metal.js/packages/metal-component/lib'
13 06 2017 09:44:58.051:INFO [Chrome 59.0.3071 (Mac OS X 10.12.5)]: Connected on socket Qc-DOvgx22kwF8SMAAAA with id 8378368
Chrome 59.0.3071 (Mac OS X 10.12.5) ERROR
  Uncaught Error: bundle error (see logs)
  at /var/folders/9d/8j0fbplx4lz15v9g77h3h48h0000gp/T/4fdcace4290d0983f054092ee84fbbdb.browserify:1

Thanks.

@mthadley
Copy link

@julien I just ran npm test on node v7.10.0 and npm 4.2.0 and saw everything passing. Did you make sure to run lerna bootstrap and npm install first?

@julien
Copy link
Contributor Author

julien commented Jun 13, 2017

Hi @mthadley,

Yes I did run lerna bootstrap and npm install first.
I'll try with node v7.x

Thanks!

@julien
Copy link
Contributor Author

julien commented Jun 13, 2017

Hey @mthadley,

That did the trick so I'll probably stick to node v7.10.0 & npm 4.2.0 for now.

However, it might be a good idea to start checking what's going on with v8.x.x

Thanks!

@julien julien closed this as completed Jun 13, 2017
@mthadley
Copy link

@julien I totally agree. Looking at our travis.yml, we should actually be including more versions in our build matrix to catch these.

\cc @jbalsas

@jbalsas
Copy link
Contributor

jbalsas commented Jun 20, 2017

Totally!

On the other hand, [email protected] is moving towards LTS, so we probably want to wait for that before we update our compatibility matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants