-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metal-position] Add ability to specify the size of the space between the element and alignElement #26
Comments
@Robert-Frampton Hey @kienD, Makes sense to me. Out of curiosity, what's the workaround you guys are currently using? Also, it seems like it would be easy to add something just to the For example, a param called |
@Robert-Frampton, We would add an offset to the side of the element that `margin-X: ${offset}px` or `{transform: translateX(${offset})px}`
I'll look into what you mentioned and will send a PR in. Thanks! |
Once this gets added in, Loop will be able to fix the issue with the indecisive hover modal! Looks cool! |
I don't think this will fix your issue with the indecisive hover modals. @Robert-Frampton, After reading @jwu910's comment, I realized that the implementation suggested above would probably introduce a bug where the element can render off screen if the offset is large enough and if I will try to look into a way we can add and account for the offset in the Thanks, |
From deprecate/metal-position#4 by @kienD
It would be useful to be able to specify the size of the space you would like between the element and alignElement for the
Align.getAlignRegion
method.I think this could be done by adding a parameter that accepts a number value to the
Align.getAlignRegion
method for the spacing size and then add or subtract the value of the spacing parameter to the values in each of the switch statements.The parameter will probably need to be added to other methods that use
Align.getAlignRegion
likeAlign.align
as well.The text was updated successfully, but these errors were encountered: