Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "lint" task using eslint doesn't complain about lack of semicolon #30

Closed
mairatma opened this issue Dec 19, 2016 · 3 comments
Closed
Labels

Comments

@mairatma
Copy link
Contributor

Running gulp lint with the new eslint task in metal/metal.js I've noticed that if I remove a semicolon from a required place, lint won't complain about it. Our previous linter complained about that, and it's useful, so we need to make sure the new one is configured to complain as well.

@bryceosterhaus could you take a look at this? It's probably just missing some configuration.

@mairatma mairatma added the bug label Dec 19, 2016
@pragmaticivan
Copy link
Contributor

If that helps: https://gist.github.com/cletusw/e01a85e399ab563b1236
http://eslint.org/docs/rules/semi

Instead using 0, put 1 as a Warning on semi attribute.

@bryceosterhaus
Copy link
Member

Sent PRs for both gulp-metal and metal.js

#37

metal/metal.js#190

@eduardolundgren
Copy link
Contributor

Pulls are merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants