Filter, destroy, re-initialize issues

[noslouch]

Hey There!

I've found something of an edge case that crops up in Backbone when moving between views. I imagine this will come up in Ember or other libraries/frameworks as well.

Test case: http://codepen.io/noslouch/debug/dEosa

If you filter an isotope layout, then destroy the isotope instance (i.e. move to another view), then reinitialize isotope (i.e. return to the view containing the isotope instance), isotope will not initialize and behave as expected.

The expected behavior is that it should initialize with the original options and all items should be visible. The actual behavior is it seems to initialize with only what's originally visible, but I'm not exactly sure what's happening.

[desandro]

Thanks for digging into this one. Looks like display was not being reset after destroy. Adding this code will resolve it:

var Item = Isotope.Item;
var _destroy = Item.prototype.destroy;
Item.prototype.destroy = function() {
  // call super
  _destroy.apply( this, arguments );
  // reset display, #741
  this.css({
    display: ''
  });
};

See http://codepen.io/desandro/pen/xjzyJ

This will be added in the next version of Isotope

[noslouch]

Sweet! I had a similar workaround in a callback I implemented. Glad to see it in the core 🍻