Install the sentencepiece headers and fix include path #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
CMakeLists.txt
Outdated
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/pytorch/tokenizers | ||
| FILES_MATCHING | ||
| PATTERN "sentencepiece_processor.h" | ||
| PATTERN "sentencepiece_trainer.h" |
Contributor
Author
There was a problem hiding this comment.
How sure are you? I see the installation code in sentence piece, but without this I did not see these headers getting installed anywhere.
Contributor
Author
There was a problem hiding this comment.
oh, spoke in person, I didn't realize that the request was just to remove sentencepiece_trainer.h not the whole install() call.
larryliu0820
approved these changes
Jul 21, 2025
I'm not sure exactly why, but we weren't installing the sentencepiece headers. We also need to set our include path to point at our installed headers.
swolchok
force-pushed
the
install-sentencepiece-headers
branch
from
6f81256 to
83aeb20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure exactly why, but we weren't installing the sentencepiece headers. We also need to set our include path to point at our installed headers.