[3/4] Properly cleanup unclosed files within generator function #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Dec 1, 2022
Contributor
NivekT
left a comment
NivekT
left a comment
There was a problem hiding this comment.
Just one question on this, but overall, this LGTM!
Will look at the rest soon
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
changed the title
ejguan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a case that
file.closeis never called because when generator function has never reached to the end. A simple example would beziptwo datepipes with different length. The longer DataPipe would never reach the end of generator and then it will be cleaned up bygc. So, the line offile.closeis not executed. (This is the reason that Vitaly has to create this hack to retrieve all remaining data to make sure generator function is fully executed)However, this hack introduces another problem where an infinite datapipe would make
zipnever end as it would try to deplete the infinite iterator. See: #865So, in this PR, I am adding a
try-finallyclause to make sure thefile.closeis always executed during the destruction ofgeneratorobject. Then, we don't need the hack withinzipany more.