Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Reported version should be match the official release #36

Closed
rgl opened this issue Nov 16, 2022 · 5 comments
Closed

Reported version should be match the official release #36

rgl opened this issue Nov 16, 2022 · 5 comments

Comments

@rgl
Copy link

rgl commented Nov 16, 2022

This is related to the change at #28.

netbird is now showing the correct version, but it seems its not quite as the official release, as it has an extra v letter prefix, and I think it should be removed. Here's a screenshot from https://app.netbird.io/peers:

image

And from the command line:

root@OpenWrt:~# netbird version
v0.10.7

Versus what is displayed by the official release:

vagrant@dm1:~$ netbird version
0.10.8
@mlsmaycon
Copy link
Contributor

opened a PR with the new version, see #37

@rgl
Copy link
Author

rgl commented Nov 16, 2022

Please note that this issue is not about upgrading to 0.10.8. It's about changing the way the version is reported, that is, v0.10.7 vs 0.10.7

@mlsmaycon
Copy link
Contributor

That's true; I totally missed that. Looking here, it seems to be all set correctly; even the workflow outputs the v0.10.7 in the ldflag, see here

Can you share the arch type you are running there?

@rgl
Copy link
Author

rgl commented Nov 16, 2022

It's amd64.

I think we need to remove the v letter at https://github.com/messense/openwrt-netbird/blob/main/netbird/Makefile#L20

@messense
Copy link
Owner

Done in fc3b11e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants