This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Reported version should be match the official release #36
Comments
Merged
opened a PR with the new version, see #37 |
Please note that this issue is not about upgrading to 0.10.8. It's about changing the way the version is reported, that is, v0.10.7 vs 0.10.7 |
That's true; I totally missed that. Looking here, it seems to be all set correctly; even the workflow outputs the v0.10.7 in the ldflag, see here Can you share the arch type you are running there? |
It's amd64. I think we need to remove the v letter at https://github.com/messense/openwrt-netbird/blob/main/netbird/Makefile#L20 |
Done in fc3b11e |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is related to the change at #28.
netbird
is now showing the correct version, but it seems its not quite as the official release, as it has an extrav
letter prefix, and I think it should be removed. Here's a screenshot from https://app.netbird.io/peers:And from the command line:
Versus what is displayed by the official release:
The text was updated successfully, but these errors were encountered: