Upgrade AAVE to 3.0.0 Schema

[bye43]

Issues to address when we do this:

Tasks

• Upgrade aave forks to latest lending schema/SDK
• Add liquidation Rev to Aave forks: #feature; Add liquidation revenue to aave #1831
• Ensure all helper fields are prepended with _ before deployment: Aave Forks underscore added fields in schema #1084
• Ensure no immutable entity IDs are changed (protocol.id, market.id) (note: this is case sensitive)
• Simplify Aave V3 (and forks) (see spark lend manifest for what to do)
• add flashloan data
• Ensure positions are properly labeled with isolation type in aave v3: Add nuance to positions #1491
• Will need to include this during upgrade: fix(#patch); aave v3; handle change to BalanceTransfer event #1669
  • need clarification
• (optional) treasury data: Aave Treasury Data #163
  • need more specifics
  • decided to not do this atm

[melotik]

Will also allow us to get aave flashloan data

[melotik]

Another note: aave v3 and forks can be refactored to be simpler (see spark lend). We might as well do that change in this PR as well

[ishraq8]

@dmelotik just to confirm, this will not effect endpoints for protocol metrics right?

[melotik]

Good point @ishraq8. We need to discuss how we can go about this from a consumption standpoint.

To answer the question, this affects endpoints. The upgrade creates breaking changes on the endpoint. But, our service already supports the schema we will be moving to in this issue.

The question is, what work needs to be done in order to support this update, if any?

Edit: The only thing we need to worry about is not changing any of the IDs (case sensitive). They should all be lowercase now, so this should not be an issue

[tnkrxyz]

I am almost done with the refactoring. @dmelotik , @bye43 , one quesiton for you is whether the upgraded subgraphs need to be QAed? Since the upgrade/refactoring adds new logics and changes existing logic (transfers), I feel more comfortable if any protocol specialist can help take a look.

[ishraq8]

@tnkrxyz happy to take a look for QA, I think it is best practice to QA these refactoring. Give me a heads up when they are ready.

[melotik]

@ishraq8 the only thing that should change is the aave v3 positions since we are now splitting them on the borrow side between stable and variable borrows.

And all of the new fields/entities from the new schema, so we should make sure they make sense, but the tvl, revenue, usage, on the protocol/pools should be exactly the same

[tnkrxyz]

@tnkrxyz happy to take a look for QA, I think it is best practice to QA these refactoring. Give me a heads up when they are ready.

@ishraq8 I made some final changes and re-deployed the subgraphs. Unfortunately, some of subgraphs will take a long time to sync (aave-v2/v3-polygon etc). I will let you know once it is fully synced.

[ishraq8]

@ishraq8 the only thing that should change is the aave v3 positions since we are now splitting them on the borrow side between stable and variable borrows.

And all of the new fields/entities from the new schema, so we should make sure they make sense, but the tvl, revenue, usage, on the protocol/pools should be exactly the same

Good to note, i figured it could be a quick look for a set of eyes.

[ishraq8]

@tnkrxyz @dmelotik went through the positional data on the v3.0.1 schemas and they are accurate compared to what is on the explorer. Positional data is accurate and depends on code review.

[tnkrxyz]

@tnkrxyz @dmelotik went through the positional data on the v3.0.1 schemas and they are accurate compared to what is on the explorer. Positional data is accurate and depends on code review.

@ishraq8 , great, thx! There are a few subgraphs that are still syncing (e.g. aave-v2-polygon, aave-v3-optimism) and will take a long time before they are fully synced. I also fixed a deployment error for aave-v2-ethereum and radiant-arbitrum. See #1993 (comment) for a complete list of subgraphs.

[melotik]

@ishraq8 can you also take a look at revenue detail in markets. The new field should separate flashloan and liquidation revenue out. Can you also verify rewards have not changed, there is some new logic

[ishraq8]

looks like revenuedetail is working. this should be good to go from QA side

[melotik]

tnkrxyz is still working on an issue from the revenue on aave v3 eth

[bye43]

@ishraq8 There is a negative revenue issue that @dmelotik has been seeing in some of the markets at the beginning of their initialization, so they might need a re-QA when the fix for that goes through

[ishraq8]

will do, thanks for heads up :)