dist: copy URLs from main configuration to avoid issues with relative… #4928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-raits
reviewed
Feb 14, 2019
igor-raits
reviewed
Feb 14, 2019
freddy77
force-pushed
the
master
branch
2 times, most recently
from
0159b80 to
6f75266
Compare
Member
|
This could really use a a test. It seems like a thing that has a high probability of breaking in the future. |
Author
|
Do you have any suggestion? I didn't find any test case related to distribution |
Member
|
|
Member
|
Ping. |
Author
|
Hi, sorry, no much time lately. I think a good test would be:
I saw the |
Member
|
|
… paths If the path in .gitmodules are specified using relative paths the "dist" target can fail. This as the main repository is cloned into a new directory so the new URLs of the sub-modules will be relative to the new directory. However if the original URLs were remote the new ones will be local and the clone will fail. Signed-off-by: Frediano Ziglio <[email protected]>
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… paths
If the path in .gitmodules are specified using relative paths the
"dist" target can fail. This as the main repository is cloned
into a new directory so the new URLs of the sub-modules will be
relative to the new directory. However if the original URLs were
remote the new ones will be local and the clone will fail.
Signed-off-by: Frediano Ziglio [email protected]