interpreter: Add hex/octal/binary support to str and int primitives #15250
+184
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
requested changes
Nov 19, 2025
cdown
force-pushed
the
cdown/2025-11-16/int_bases
branch
from
ce586d4 to
cf4e844
Compare
dnicolodi
reviewed
Nov 28, 2025
dnicolodi
reviewed
Nov 28, 2025
Add support for parsing and formatting integers in hexadecimal, octal, and binary representations to complement the existing decimal support. str.to_int() now accepts strings with 0x/0o/0b prefixes and optional leading signs (+/-), enabling direct parsing of hex, octal, and binary literals while maintaining full backward compatibility with decimal strings including those with leading zeros. int.to_string() gains a new format keyword argument that accepts 'dec', 'hex', 'oct', or 'bin', allowing integers to be formatted with appropriate prefixes (0x, 0o, 0b). The format parameter works correctly with the existing fill parameter and handles negative numbers properly. Round-trip conversions are fully supported: values formatted with int.to_string(format: 'hex') can be parsed back with str.to_int(). Fixes: mesonbuild#2047 Fixes: mesonbuild#15201
cdown
force-pushed
the
cdown/2025-11-16/int_bases
branch
from
cf4e844 to
d50cfec
Compare
dnicolodi
reviewed
Nov 28, 2025
| return str(self.held_object).zfill(kwargs['fill']) | ||
| def to_string_method(self, args: T.List[TYPE_var], kwargs: 'ToStringKw') -> str: | ||
| format_codes = {"hex": "x", "oct": "o", "bin": "b", "dec": "d"} | ||
| return format(self.held_object, f'#0{kwargs["fill"]}{format_codes[kwargs["format"]]}') |
Member
There was a problem hiding this comment.
Suggested change
| return format(self.held_object, f'#0{kwargs["fill"]}{format_codes[kwargs["format"]]}') | |
| return '{:#0{fill}{format}}'.format(self.held_object, fill=kwargs['fill'], format=format_codes[kwargs['format']]) |
dnicolodi
reviewed
Nov 28, 2025
| class ToStringKw(TypedDict): | ||
|
|
||
| fill: int | ||
| format: Literal["dec", "hex", "oct", "bin"] |
Member
There was a problem hiding this comment.
I think the quoting style in the meson code base is to use single quotes.
dnicolodi
reviewed
Nov 28, 2025
Comment on lines
+135
to
+147
| s = self.held_object.strip() | ||
| s_unsigned = s.lstrip('+-').lower() | ||
|
|
||
| if s_unsigned.startswith('0x'): | ||
| base = 16 | ||
| elif s_unsigned.startswith('0o'): | ||
| base = 8 | ||
| elif s_unsigned.startswith('0b'): | ||
| base = 2 | ||
| else: | ||
| base = 10 | ||
|
|
||
| return int(s, base) |
Member
There was a problem hiding this comment.
Suggested change
| s = self.held_object.strip() | |
| s_unsigned = s.lstrip('+-').lower() | |
| if s_unsigned.startswith('0x'): | |
| base = 16 | |
| elif s_unsigned.startswith('0o'): | |
| base = 8 | |
| elif s_unsigned.startswith('0b'): | |
| base = 2 | |
| else: | |
| base = 10 | |
| return int(s, base) | |
| return int(s, base=0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing and formatting integers in hexadecimal, octal, and binary representations to complement the existing decimal support.
str.to_int() now accepts strings with 0x/0o/0b prefixes and optional leading signs (+/-), enabling direct parsing of hex, octal, and binary literals while maintaining full backward compatibility with decimal strings including those with leading zeros.
int.to_string() gains a new format keyword argument that accepts 'dec', 'hex', 'oct', or 'bin', allowing integers to be formatted with appropriate prefixes (0x, 0o, 0b). The format parameter works correctly with the existing fill parameter and handles negative numbers properly.
Round-trip conversions are fully supported: values formatted with
int.to_string(format: 'hex') can be parsed back with str.to_int().
Fixes: #2047
Fixes: #15201