[Bug]: Traceroutes via ROUTER_LATE node dont end up in the TX Queue after modification (to add self hop in rebroadcast) on return path!

[Talie5in]

Category

Other

Hardware

Linux Native

Firmware Version

2.5.20

Description

When doing a traceroute via a ROUTER_LATE node, traceroutes are seen leaving, and coming back, but not modifying and putting itself into the TX queue to rebroadcast, therefor traceroute never gets returned to source node - so a return path only issue.

Captured in DEBUG Log on node setup in ROUTER_LATE

TR_Repose_NoRequeue.txt

Relative Isolated Test Environment,
If i take source node for a walk to where it does in fact get direct sight to another CLIENT node or the destination node directly, traceroute works from a RAK4631 in CLIENT_MUTE and receives the response.

Relevant log output

[erayd]

Thanks @Talie5in - I will try to tackle this tomorrow or Thursday. I need to dig into the traceroute code anyway for #5534, so this is good additional motivation for me to do so!

[erayd]

Have managed to replicate the lack of traceroute response via ROUTER_LATE. Now I just need to figure out why it's happening...

[GUVWAF]

@Talie5in Which exact commit were you using when testing this? I can't find the string "Incoming msg will be filtered, from" from your log in the source code. So I'm not sure where that is coming from, but a bit later it mentions cancelSending id=0x827fe923, removed=1 meaning it removed it from the Tx queue.

[GUVWAF]

It seems to be coming from your modified firmware:
https://github.com/Talie5in/mt-device-firmware/blob/02b2ee8883663618a0c6319fc37fe137a6d2ac25/src/mesh/Router.cpp#L574

I believe this is your issue. You're canceling a packet in the Tx queue when another arrives. For ROUTER_LATE this is more likely to happen as it delays the rebroadcast.

[erayd]

I wonder what it was that I was reproducing then? Because I can get the behaviour to recur here.