Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

[Bug] Incorporate Adapter Version # at buildtime #111

Closed
mgfeller opened this issue Aug 30, 2021 · 1 comment · Fixed by #112
Closed

[Bug] Incorporate Adapter Version # at buildtime #111

mgfeller opened this issue Aug 30, 2021 · 1 comment · Fixed by #112
Assignees
Labels
kind/bug Something isn't working

Comments

@mgfeller
Copy link
Contributor

Description

build-args main.version=$VERSION and main.gitsha=$GIT_COMMITSHA are not being picked up.

Expected Behavior

when testing locally e.g. building using
GOPROXY=direct GOSUMDB=off go build -ldflags="-w -s -X main.version=VERSION -X main.gitsha=GIT_COMMITSHA" -a -o ./meshery-osm .

and running ./meshery-osm

expected result of grpcurl --plaintext 127.0.0.1:10009 meshes.MeshService.ComponentInfo

{
  "type": "adapter",
  "name": "OPEN_SERVICE_MESH",
  "version": "VERSION",
  "gitSha": "GIT_COMMITSHA"
}
@welcome
Copy link

welcome bot commented Aug 30, 2021

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant