-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better TypeScript support #1
Comments
@aliogaili I'll try to make a PR when I have some free time. I just wanted to let you know in case you can take a look at it before I do. |
No worries, I'm glad it saved you some time, I don't use typescript but I'll be happy to merge your PR. |
Also once you submit the PR I'll make the preview copy configurable so you can adjust how you want the copy code to look like so it works for your project. |
haven't done the typescript part ? I am receiving error on this line
|
Not really, I don't use TS much. But I can get it done if you want to get it started. |
@aogaili yes needed typescript is recommended and it should support that |
First of all, thanks a lot for making this fork! I was about to make my own fork or switch to another library since
react-icons
was increasing our bundle size around 10mb. Our bundle size is greatly reduced after switching to@meronex/icons
, but there's an issue with generated types.This works:
But this is not recognized by TypeScript:
The text was updated successfully, but these errors were encountered: