Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: "newDagreD3" switch in the flowchart renderer is no longer needed and can be removed #1182

Closed
GDFaber opened this issue Jan 6, 2020 · 1 comment · Fixed by #1189
Closed

Maintenance: "newDagreD3" switch in the flowchart renderer is no longer needed and can be removed #1182

GDFaber opened this issue Jan 6, 2020 · 1 comment · Fixed by #1189
Assignees
@GDFaber
Labels
Area: Development Graph: Flow Retained Nonperishable Status: Approved Is ready to be worked on Type: Enhancement New feature or request

Comments

@GDFaber
Copy link
Member

GDFaber commented Jan 6, 2020

In order to move safely to the dagre-d3 branch, the flowchart renderer was given the possibility to switch between old and new version for testing purposes. This switch can now be removed.

This issue is a reminder for removing the code for the old dagre-d3 variant in the flowchart renderer. I'll PR the change after #1176 has been successfully merged because maybe there would be merge conflicts.
@GDFaber GDFaber added Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request labels Jan 6, 2020
@GDFaber GDFaber changed the title Maintenance: "newDagreD3" switch is no longer needed and can be removed Maintenance: "newDagreD3" switch in the flowchart renderer is no longer needed and can be removed Jan 6, 2020
@klemmchr klemmchr added Area: Development Graph: Flow Contributor needed Retained Nonperishable Status: Approved Is ready to be worked on and removed Status: Triage Needs to be verified, categorized, etc labels Jan 6, 2020
@GDFaber GDFaber mentioned this issue Jan 8, 2020
Merged
3 tasks
@GDFaber
Copy link
Member Author

GDFaber commented Jan 8, 2020

done

@knsv knsv closed this as completed in #1189 Jan 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GDFaber GDFaber

Labels
Area: Development Graph: Flow Retained Nonperishable Status: Approved Is ready to be worked on Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Maintenance/Remove "newDagreD3" switch from the flowchart renderer
3 participants
@IOrlandoni @GDFaber @klemmchr